model mod: parameter change appears as code mod!

[charlotte]

I'm working with the questionnaire in Gerry's branch. I just described a model mod as a parameter change but it appears as type=codemod in the list of model mods - see screen shots.
 description  list

[charlotte]

Parameter change appears as a code mod

[gerry]

I moved this from critical to major. The information is being stored correctly in the database, but rendered incorrectly. Will fix in due course

[charlotte]

Changing the priority to blocker version 1.1 release, I think it is important that users see the correct info when they select something - even if the database is correct.

[charlotte]

It seems that the type associated with the model modifications and input modifications has nothing to do with the type that users choose in the drop down lists when they describe them! 

Input modifications have three types which users choose from a drop-down list - Ancillary file, Initial Condition and Boundary Condition. Yet when the input mod appears on the list of mods associated with a simulation we see that it listed as name(inputmod). So it has type=inputmod, not ancillary file/initial condition/boundary condition.
http://127.0.0.1:8000/cmip5/39/list/ inputmod /ensemble/1

Similarly, the model mods are given type = codemod yet the user had been offered the choice of Parameter Change or Code Change to describe the type.
http://127.0.0.1:8000/cmip5/39/list/ modelmod /ensemble/1

[charlotte]

Gerry, I'm handing this one over to you because I really don't understand forms!

[charlotte]

What should type signify for our model mods and input mods?

The questionnaire seems to be using type to distinguish input mods from model mods.
Confusion arose for me because the model mod type is called a code mod and I confused the code mod modification type with the code change model modification type.

So I think we can make this much clearer if we change
modification type = code mod 
to
modification type = model mod

But I don't know which piece of python code  or template html needs to be changed to do this!

[rupert]

Any change to type could affect the q2cim software so I've added the subCMIP5 keyword. This ticket should be reassigned to me if the type is changed, or another ticket created so I can make any necessary changes.

[charlotte]

I think it is best not to change the CIM but rather to put a clearer explanation on the questionnaire - not a subCMIP5 issue