Ticket #679 (closed Task: fixed)

Opened 2 years ago

Last modified 19 months ago

Realm names of components should match DRS ones

Reported by: mariepierre Owned by: bryan
Priority: critical Milestone: V1.1 Questionnaire Release
Component: WP6 - CMIP5 Questionnaire Version: beta
Keywords: Cc: gerry, rupert
Requirement: http://metaforclimate.eu/Work-Package-2/Developing-the-CIM/Project-Requirements-summary.htm

Description

Action from Telco 67.

Currently, the names used for realms components in the Questionnaire are not the DRS ones:

realm names in the Qnairerealm names in the DRS
(values for "modeling-realm")
Atmosphereatmos
Oceanocean
Land Surfaceland
Land IcelandIce
Sean IceseaIce
Aerosolsaerosol
Atmospheric ChemistryatmosChem
Ocean BiogeochemistryOcnBgchem

At the end (in Qnaire xml outputs / CIM instances) the realms names must match the DRS.

The discussion is whether we change the realms names directly in the mindMaps (manually) or entrust the translation task to the mm2q parser.

Change History

comment:1 Changed 2 years ago by gerry

Hi Marie-Pierre, I have sent these mappings to Rupert yesterday and he is currently in the process of uploading these into his outputting tool. No changes are needed to the mindmaps therefore.

comment:2 Changed 2 years ago by mariepierre

OK, good news! :-)

Anyway, I recap our arguments in the next comment.

comment:3 Changed 2 years ago by mariepierre

Some argumentation from previous e-mails exhanges...

Bryan (e-mail on Feb. 25th):

![...] We should match the DRS, however we achieve it ...


MariePierre (e-mail on March 1st):

![...] Bryan's reply implies that we could match the DRS by different ways ? I imagine the fist way is the solution you propose (modifying directly the names in the mindMaps). Another one could be include a translation rule (e.g.OceanBiogeoChemistry --> ocnBgchem) in the "generate CIM xml document" step?

Gerry (e-mail on March 1st):

![...] I agree there are several ways to do this. I have no problem going through and making these changes manually but there are two arguments for doing this via the translation code: (1) as you have said, it will maintain the readability in the qn, and (2) I've realised that for the other CV changes (non-mindmap) that Sylvia and I have 'scrubbed' that changing these does clash with the questionnaire code in places (example below); and so a modification at the translator stage (for esg harvesting) would be the most ideal. Rupert, Is this something that is easy to do? If not, I will look at alternative ways to implement the changes requested by Sylvia.

Example clash:
Sylvia requested change from 'InitialCondition' to 'Initial Condition' (with a space).
Unfortunately, the qn code has hardcoded checks in numerous places for if value='InitialCondition'.
This would mean going through the code and replacing all instances of this, which doesn't look very feasable.

comment:4 Changed 19 months ago by rupert

  • Status changed from new to closed
  • Resolution set to fixed

We provide both METAFOR and DRS model types in the questionnaire output.

Note: See TracTickets for help on using tickets.